This repository has been archived by the owner on Nov 2, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 440
Add support for offline transaction signing #2907
Open
lukechampine
wants to merge
29
commits into
master
Choose a base branch
from
offline-signing
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
d39e94f
add offline signing functionality
lukechampine 1c7efd4
sync before reporting wallet height
lukechampine 4fa416a
add api routes for unspent+sign
lukechampine e959025
add api docs for unspent+sign
lukechampine 6332d01
change sign semantics
lukechampine b3741e7
add wallet sign command
lukechampine 41c5410
generate keys incrementally
lukechampine 32059e7
use new SpendableOutput type for /unspent
lukechampine 277d93a
sign SiafundInputs as well
lukechampine 873500b
Add siatest and client integration for offline signing
ChrisSchinnerl 043674b
Merge pull request #2913 from NebulousLabs/offline-signing-siatest
lukechampine a2bcb24
Merge branch 'master' into offline-signing
90566ab
decode directly into toSign map
lukechampine d408cc1
add docstrings
lukechampine 4050676
document tosign types
lukechampine 64ff690
account for unconfirmed txns in SpendableOutputs
lukechampine 78c2a13
add wallet sign -raw flag, JSON by default
lukechampine d2c89fc
try /wallet/sign before doing keygen
lukechampine c5098c8
include UnlockConditions in SpendableOutput
lukechampine c1c14d7
Revert "include UnlockConditions in SpendableOutput"
lukechampine 0514348
Merge branch 'master' into offline-signing
lukechampine 6b22c87
don't include unconfirmed outputs that may be spent
lukechampine 477a497
add UnlockConditions to SpendableOutput
lukechampine c36c14e
Merge branch 'master' into offline-signing
lukechampine 30a5854
Merge branch 'master' into offline-signing
lukechampine 83967e1
fix TransactionPoolRawPost signature
lukechampine 4fccafd
add wallet broadcast cmd
lukechampine c97a9d7
more helpful signature decoding error
lukechampine f174e41
overhaul SignTransaction
lukechampine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably mention that those are
SiacoinOutputID: UnlockHash/Address
pairs.