Skip to content

Commit

Permalink
Credit GroupsCore.jl for origin of groups interface (#1641)
Browse files Browse the repository at this point in the history
  • Loading branch information
fingolfin authored Apr 11, 2024
1 parent 1d9eef1 commit 7da1c96
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 4 deletions.
11 changes: 8 additions & 3 deletions LICENSE.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,13 @@
As AbstractAlgebra links dynamically at runtime with various libraries included with Julia, all of whose licenses are compatible with GPL v3+, you may safely distribute AbstractAlgebra *as a whole* under the terms of that license. See for example the MPFR or GMP licenses in the Julia distribution, or refer to the GPL online here:
As AbstractAlgebra links dynamically at runtime with various libraries
included with Julia, all of whose licenses are compatible with GPL v3+, you
may safely distribute AbstractAlgebra *as a whole* under the terms of that
license. See for example the MPFR or GMP licenses in the Julia distribution,
or refer to the GPL online here:

https://www.gnu.org/copyleft/gpl.txt
<https://www.gnu.org/copyleft/gpl.txt>

Individual parts of AbstractAlgebra may be distributed according to more permissive terms as laid out below:
Individual parts of AbstractAlgebra may be distributed according to more
permissive terms as laid out below:

* The individual .jl files in the AbstractAlgebra.jl package are licensed under the Simplified "2-clause" BSD License:

Expand Down
11 changes: 11 additions & 0 deletions src/Groups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,17 @@
#
# Groups.jl : AbstractAlgebra groups
#
#
# The code in this file is based on v0.4 of the GroupsCore.jl package, which
# is copyright (c) 2021 Marek Kaluba <[email protected]> and contributors,
# and licensed under the MIT license <https://spdx.org/licenses/MIT.html>.
#
# The interfaces have since then diverged, with several breaking changes.
# Function and type names differ (e.g. `istrivial` vs. `is_trivial`), and
# also semantics (e.g. definition of equality for group elements in
# GroupsCore allows returning false for mathematically equal elements when it
# is "too hard" to prove equality; we don't).
#
###############################################################################

###############################################################################
Expand Down
18 changes: 17 additions & 1 deletion test/Groups-conformance-tests.jl
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
# TODO: add acknowledgements for GroupsCore
###############################################################################
#
# Conformance tests for the group and group element interfaces.
#
#
# The code in this file is based on v0.4 of the GroupsCore.jl package, which
# is copyright (c) 2021 Marek Kaluba <[email protected]> and contributors,
# and licensed under the MIT license <https://spdx.org/licenses/MIT.html>.
#
# The interfaces have since then diverged, with several breaking changes.
# Function and type names differ (e.g. `istrivial` vs. `is_trivial`), and
# also semantics (e.g. definition of equality for group elements in
# GroupsCore allows returning false for mathematically equal elements when it
# is "too hard" to prove equality; we don't).
#
###############################################################################


function test_Group_interface(G::Group)
@testset "Group interface" begin
Expand Down

0 comments on commit 7da1c96

Please sign in to comment.