-
Notifications
You must be signed in to change notification settings - Fork 64
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Credit GroupsCore.jl for origin of groups interface (#1641)
- Loading branch information
Showing
3 changed files
with
36 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,17 @@ | |
# | ||
# Groups.jl : AbstractAlgebra groups | ||
# | ||
# | ||
# The code in this file is based on v0.4 of the GroupsCore.jl package, which | ||
# is copyright (c) 2021 Marek Kaluba <[email protected]> and contributors, | ||
# and licensed under the MIT license <https://spdx.org/licenses/MIT.html>. | ||
# | ||
# The interfaces have since then diverged, with several breaking changes. | ||
# Function and type names differ (e.g. `istrivial` vs. `is_trivial`), and | ||
# also semantics (e.g. definition of equality for group elements in | ||
# GroupsCore allows returning false for mathematically equal elements when it | ||
# is "too hard" to prove equality; we don't). | ||
# | ||
############################################################################### | ||
|
||
############################################################################### | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,20 @@ | ||
# TODO: add acknowledgements for GroupsCore | ||
############################################################################### | ||
# | ||
# Conformance tests for the group and group element interfaces. | ||
# | ||
# | ||
# The code in this file is based on v0.4 of the GroupsCore.jl package, which | ||
# is copyright (c) 2021 Marek Kaluba <[email protected]> and contributors, | ||
# and licensed under the MIT license <https://spdx.org/licenses/MIT.html>. | ||
# | ||
# The interfaces have since then diverged, with several breaking changes. | ||
# Function and type names differ (e.g. `istrivial` vs. `is_trivial`), and | ||
# also semantics (e.g. definition of equality for group elements in | ||
# GroupsCore allows returning false for mathematically equal elements when it | ||
# is "too hard" to prove equality; we don't). | ||
# | ||
############################################################################### | ||
|
||
|
||
function test_Group_interface(G::Group) | ||
@testset "Group interface" begin | ||
|