Apply suggestions from code review

Nemocas · Feb 7, 2024 · 892c741 · 892c741
1 parent beb1897
commit 892c741
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/AbstractAlgebra.jl b/src/AbstractAlgebra.jl
@@ -592,6 +592,7 @@ import .Generic: hash
 import .Generic: hooklength
 import .Generic: image_fn
 import .Generic: image_map
+import .Generic: internal_ordering
 import .Generic: interreduce!
 import .Generic: inv!
 import .Generic: inverse_fn
@@ -637,7 +638,6 @@ import .Generic: normalise
 import .Generic: num_coeff
 import .Generic: one
 import .Generic: order
-import .Generic: internal_ordering
 import .Generic: parity
 import .Generic: partitionseq
 import .Generic: perm
@@ -854,6 +854,7 @@ export image_fn
 export image_map
 export inflate
 export integral
+export internal_ordering
 export interpolate
 export inv!
 export invariant_factors
@@ -986,7 +987,6 @@ export O
 export one
 export one!
 export order
-export internal_ordering
 export parent_type
 export parity
 export Partition

diff --git a/src/Deprecations.jl b/src/Deprecations.jl
@@ -29,4 +29,4 @@ end
 Base.@deprecate_binding intersection intersect
 
 # deprecated in 0.37.x
-Base.@deprecate_binding ordering internal_ordering
+@deprecate ordering(R::MPolyRing) internal_ordering(R::MPolyRing)
diff --git a/src/MPoly.jl b/src/MPoly.jl
@@ -1211,7 +1211,7 @@ end
 ################################################################################
 
 function _change_mpoly_ring(R, Rx, cached)
-   P, _ = polynomial_ring(R, map(string, symbols(Rx)), internal_ordering = internal_ordering(Rx), cached = cached)
+   P, _ = polynomial_ring(R, map(string, symbols(Rx)); internal_ordering = internal_ordering(Rx), cached = cached)
    return P
 end