Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul Unicode preferences #1586
Overhaul Unicode preferences #1586
Changes from 3 commits
69f8cab
744e01c
0b5aa58
3cda20d
6108fee
f2228bc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 1412 in src/PrettyPrinting.jl
src/PrettyPrinting.jl#L1407-L1412
Check warning on line 1417 in src/PrettyPrinting.jl
src/PrettyPrinting.jl#L1414-L1417
Check warning on line 1430 in src/PrettyPrinting.jl
src/PrettyPrinting.jl#L1427-L1430
Check warning on line 1444 in src/PrettyPrinting.jl
src/PrettyPrinting.jl#L1439-L1444
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we have no tests for
with_unicode
in AA` :-(. But of course this is out of scope for this PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true. But after thinking again about it, this seems to be kind of hard anyway:
Calling
allow_unicode()
from the test would change the user preferences while running tests (not a great experience for devs), and from a withinwith_unicode
blockallow_unicode
is unsafe.But overall, we should postpone it
Check warning on line 1447 in src/PrettyPrinting.jl
src/PrettyPrinting.jl#L1446-L1447