fix: make dot work again #1593
Merged
fix: make dot work again #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Feb 2, 2024
|
We already have AbstractAlgebra.jl/src/NemoStuff.jl Line 402 in c563d60 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1593 +/- ##
=======================================
Coverage 87.17% 87.17%
=======================================
Files 115 115
Lines 29565 29567 +2
=======================================
+ Hits 25773 25776 +3
+ Misses 3792 3791 -1 ☔ View full report in Codecov by Sentry. |
lgoettgens
reviewed
Feb 2, 2024
src/Rings.jl
Outdated
|
|
||
| dot(x::NCRingElem, y::Union{Integer, Rational, AbstractFloat}) = x * y | ||
|
|
||
| dot(x::Union{Integer, Rational, AbstractFloat}, y::NCRingElem) = x * y |
There was a problem hiding this comment.
Can you move all of this to src/NCRings.jl to match the test file?
Co-authored-by: Lars Göttgens <[email protected]>
lgoettgens
approved these changes
Feb 2, 2024
ooinaruhugh
pushed a commit
to ooinaruhugh/AbstractAlgebra.jl
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.