Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old deprecations #1605

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

Removes all deprecations that were present in the last (0.14.0) Oscar release to reduce the number of deprecations for 1.0.
Removing the other ones as well would be inconvenient for users of Oscar since they miss the deprecation stage of those type names.

x-ref: oscar-system/Oscar.jl#3356

Copy link
Member

@thofma thofma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the test error is real.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (19dee66) 86.95% compared to head (64062eb) 86.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1605      +/-   ##
==========================================
+ Coverage   86.95%   86.97%   +0.01%     
==========================================
  Files         115      114       -1     
  Lines       29628    29622       -6     
==========================================
  Hits        25764    25764              
+ Misses       3864     3858       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma merged commit e2292c2 into Nemocas:master Feb 13, 2024
29 of 30 checks passed
@lgoettgens lgoettgens deleted the lg/deprecations-AA branch February 15, 2024 11:00
ooinaruhugh pushed a commit to ooinaruhugh/AbstractAlgebra.jl that referenced this pull request Feb 15, 2024
* Remove old deprecations

* Remove non-existent export

* Replace deprecated uses of `intersection`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants