Cleanup after name printing changes #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as this is part of the "old" interface that should not get called directly anymore
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1613 +/- ##
=======================================
Coverage 86.98% 86.99%
=======================================
Files 114 114
Lines 29686 29686
=======================================
+ Hits 25822 25824 +2
+ Misses 3864 3862 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1594 defined a new interface but kept everything non-breaking to ease the adaption.
Oscar and Hecke have been adapted in oscar-system/Oscar.jl#3327 and thofma/Hecke.jl#1393 to use the new interface.
This is now the following change, that is technically breaking, but shouldn't need any changes in Hecke and Oscar (let this be verified by CI) due to the earlier adaption.