Use supercompact on field/ring in show method for FreeModule #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
- Coverage 86.76% 86.76% -0.01%
==========================================
Files 114 114
Lines 29696 29696
==========================================
- Hits 25767 25766 -1
- Misses 3929 3930 +1 ☔ View full report in Codecov by Sentry. |
|
unfortunately breaks oscar doctests |
|
Yeah I was afraid this would happen. Ah well. The reported breakage is actually somewhat bad, it changes |
The code predates supercompact and was using compact. Now it uses both supercompact and compact. We probably should make similar changes in more places...
fingolfin
force-pushed
the
mh/supercompact-free-module-vector-space
branch
from
6c48ebd to
cab7dc6
Compare
|
Superseded by #1680 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code predates supercompact and was using compact. Now it uses
both supercompact and compact.
We probably should make similar changes in more places...