Clean up some linear solving methods #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
==========================================
- Coverage 87.00% 86.76% -0.24%
==========================================
Files 114 114
Lines 29707 29689 -18
==========================================
- Hits 25846 25761 -85
- Misses 3861 3928 +67 ☔ View full report in Codecov by Sentry. |
thofma
reviewed
Mar 14, 2024
|
Maybe also add an |
* `_can_solve_with_solution` * `_can_solve` * `_solve` * `_solve_left`
|
Happy with the coverage? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can_solve_with_*methods and friends.Solve.*code to use more specialized methods forFracElem.The remaining
_can_solve_with_solution_*methods over rings all do "rational solutions" and we should think about how we want to make this available to the user.The other question is, whether the user should be able to choose an algorithm, so whether
can_solve_with_solutionshould for example have analgorithmkeyword where one can switch to LU factoring.