Fix handling of line break characters in a string in pretty printing #1636
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves oscar-system/Oscar.jl#3515.
The field
io.printed
should keep track of the width already printed in the current line (indentation is not tracked here).In two places, a newline char was printed, but the field was not reset to 0.
There is unfortunately no way to test this in a doctest, as all of this linebreaking business is skipped for doctests.
In local testing, this both resolves the MWE in oscar-system/Oscar.jl#3515 (comment), and the printing issues with
MonomialBasis
(at least those that I could observe locally).cc @benlorenz @lkastner