-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix all uses of Val
#1664
Fix all uses of Val
#1664
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1664 +/- ##
==========================================
- Coverage 86.92% 85.29% -1.64%
==========================================
Files 115 116 +1
Lines 29692 29700 +8
==========================================
- Hits 25810 25332 -478
- Misses 3882 4368 +486 ☔ View full report in Codecov by Sentry. |
Breaks upstream CI:
|
The two failures are |
Val{T}
is a type andVal(T)
its singleton object. This is now the way it is described in the julia docs (https://docs.julialang.org/en/v1/manual/types/#%22Value-types%22).Everything should be backward compatible due to added deprecations.