Add missing parentheses in stacked printing of univpolys #1667
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following example:
The missing parentheses in the last output are clearly misleading, and create an ambiguity between
(x+1)*y
andx+1*y
.This PR addresses this issue by replacing the printing of univ polys by using the expressify output of the underlying MPolyRing. This then fixes the recursive call of expressify on the coefficients of the polyring
S
.Let's hope that this behavior is not doctested downstream and can be released quickly.