Add ignore_kwargs to @attr macro
#1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1958 +/- ##
=======================================
Coverage 88.22% 88.23%
=======================================
Files 119 119
Lines 30430 30439 +9
=======================================
+ Hits 26848 26857 +9
Misses 3582 3582 ☔ View full report in Codecov by Sentry. |
|
Thank you @lgoettgens , this change will make my (and hopefully also the code of others) cleaner. I am therefore very much looking forward to this change. |
fingolfin
approved these changes
Jan 16, 2025
This was referenced Jan 16, 2025
Merged
aaruni96
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See oscar-system/Oscar.jl#1255 (comment) for the motivation and details.
Is that something that we want to have?
cc @HereAround