-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more special Solve.*
methods
#1668
Conversation
`hnf(lazy_transpose(A))` would not use the correct HNF method, so we have to really transpose in this case
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1668 +/- ##
==========================================
+ Coverage 84.36% 84.41% +0.04%
==========================================
Files 93 93
Lines 37159 37234 +75
==========================================
+ Hits 31350 31431 +81
+ Misses 5809 5803 -6 ☔ View full report in Codecov by Sentry. |
Good to go, but needs Nemocas/AbstractAlgebra.jl#1598 . TODO (so I still know this on Monday):
|
Add some special
Solve.kernel
methods for types coming from flint or non-domain rings. All of this is more or less taken fromHeckeMiscMatrix.jl
.I add tests in the next days; I just wanted to push this to ask about some things before I forget them.