Fix heap buffer overflow in setVersionInfo #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I caught this bug running the connection code with the address sanitzier turned on. `sizeof` returns the size of the object representation of the type argument at compile time. This can differ from the actual size of `[stringData bytes]` depending on the length of the string. If the string used to construct the data was smaller than the value returned by `sizeof`, this memcopy will read beyond the `stringData` buffer and copy potentially unitialized/garbage data into `appVer`. `[stringData length]` will return the actual length of the buffer provided by `[stringData bytes]`
|
cc @Jin-neo in case you don't get a notification when I open these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I caught this bug running the connection code with the address sanitizer turned on.
sizeofreturns the size of the object representation of the type argument atcompile time. This can differ from the actual size of
[stringData bytes]depending onthe length of the string. If the string used to construct the data was smaller than the
value returned by
sizeof, this memcopy will read beyond thestringDatabuffer andcopy potentially unitialized/garbage data into
appVer.[stringData length]will return the actual length of the buffer provided by[stringData bytes]