Fix bug causing dialog tests to pass when translations are missing #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor dialog tests to reference skill object instead of files
Merged
NeonDaniel
added a commit
that referenced
this pull request
Dec 11, 2023
# Changelog ## [0.0.2a6](https://github.com/NeonGeckoCom/neon-minerva/tree/0.0.2a6) (2023-12-08) [Full Changelog](0.0.2a5...0.0.2a6) **Merged pull requests:** - Move packages with system dependencies to `padatious` extras [\#13](#13) ([NeonDaniel](https://github.com/NeonDaniel)) ## [0.0.2a5](https://github.com/NeonGeckoCom/neon-minerva/tree/0.0.2a5) (2023-12-08) [Full Changelog](0.0.1...0.0.2a5) **Merged pull requests:** - Update GHA to publish pre-releases [\#12](#12) ([NeonDaniel](https://github.com/NeonDaniel)) - Fix bug causing dialog tests to pass when translations are missing [\#11](#11) ([NeonDaniel](https://github.com/NeonDaniel)) - Add support for CBF Submind tests [\#10](#10) ([NeonDaniel](https://github.com/NeonDaniel)) - Add compat. reference for `bus.emitter` [\#9](#9) ([NeonDaniel](https://github.com/NeonDaniel)) - Skill Test Class [\#5](#5) ([NeonDaniel](https://github.com/NeonDaniel)) \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update to resolve local test config bug
Refactor dialog tests to reference skill object instead of files
Issues
Other Notes