Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expands entry point to install dependencies from extra_dependencies config #165

Merged

Conversation

dblencowe
Copy link
Contributor

Description

Once NeonGeckoCom/neon-utils#499 is approved and merged I'll update the module requirements with a minimum neon-utils version.

  • Expand the entrypoint with an additional command, "install-dependencies" command
  • Add utility function for building a dependency list from extra_dependencies and modules or fallbacks specified in TTS configuration
  • Mark neon_audio.utils.install_tts_plugin as deprecated

Issues

NeonGeckoCom/neon_enclosure#84

Other Notes

@dblencowe dblencowe marked this pull request as draft February 3, 2024 13:08
@dblencowe dblencowe force-pushed the feat/plugin-installation-from-config branch 7 times, most recently from 07f5156 to c3e46b9 Compare February 6, 2024 15:22
neon_audio/utils.py Outdated Show resolved Hide resolved
neon_audio/utils.py Outdated Show resolved Hide resolved
neon_audio/utils.py Outdated Show resolved Hide resolved
neon_audio/cli.py Show resolved Hide resolved
neon_audio/cli.py Show resolved Hide resolved
@dblencowe dblencowe force-pushed the feat/plugin-installation-from-config branch 9 times, most recently from d950b1a to 1bb9d1e Compare February 15, 2024 19:04
@dblencowe dblencowe marked this pull request as ready for review February 16, 2024 10:08
neon_audio/utils.py Outdated Show resolved Hide resolved
requirements/requirements.txt Outdated Show resolved Hide resolved
@dblencowe dblencowe force-pushed the feat/plugin-installation-from-config branch from 1bb9d1e to 3a26d55 Compare February 22, 2024 09:15
@NeonDaniel
Copy link
Member

Tested locally and in k8s

@NeonDaniel NeonDaniel merged commit d76e9ae into NeonGeckoCom:dev Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants