Skip to content

Commit

Permalink
Update dependencies (#82)
Browse files Browse the repository at this point in the history
* Update ovos-phal dependency and remove patched requirements

* Update for compat. with upstream PHAL changes

* Troubleshooting docker dependency resolution

* Fix typo in deprecation log

---------

Co-authored-by: Daniel McKnight <[email protected]>
  • Loading branch information
NeonDaniel and NeonDaniel authored Dec 29, 2023
1 parent 1a04ed0 commit df75056
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 12 deletions.
7 changes: 6 additions & 1 deletion neon_enclosure/admin/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ def __init__(self, skill_id="neon.phal_admin", **kwargs):
AdminPHAL.__init__(self, skill_id=skill_id, **kwargs)
self.status.set_alive()
self.started = Event()
self.config = self.config or dict() # TODO: Fixed in ovos_PHAL 0.0.5a1

@property
def config(self):
from ovos_utils.log import log_deprecation
log_deprecation("Reference `admin_config`", "2.0.0")
return self.admin_config

def start(self):
LOG.info("Starting Admin PHAL")
Expand Down
11 changes: 8 additions & 3 deletions neon_enclosure/service.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,16 @@ def __init__(self, skill_id="neon.phal", **kwargs):
PHAL.__init__(self, skill_id=skill_id, **kwargs)
self.status.set_alive()
self.started = Event()
self.config = self.config or dict() # TODO: Fixed in ovos_PHAL 0.0.5a1

@property
def config(self):
from ovos_utils.log import log_deprecation
log_deprecation("Reference `user_config`", "2.0.0")
return self.user_config

def start(self):
LOG.debug("Starting PHAL")
if self.config.get('wait_for_gui'):
if self.user_config.get('wait_for_gui'):
LOG.info("Waiting for GUI Service to start")
timeout = time() + 30
while time() < timeout:
Expand All @@ -59,7 +64,7 @@ def start(self):
def load_plugins(self):
for name, plug in find_phal_plugins().items():
LOG.info(f"Loading {name}")
config = self.config.get(name) or {}
config = self.user_config.get(name) or {}
try:
if hasattr(plug, "validator"):
enabled = plug.validator.validate(config)
Expand Down
6 changes: 3 additions & 3 deletions requirements/docker.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
ovos-phal-plugin-homeassistant~=0.0.1
ovos-phal-plugin-homeassistant~=0.0.3
ovos-phal-plugin-notification-widgets~=1.0.0
ovos-phal-plugin-color-scheme-manager~=1.0.0
ovos-phal-plugin-configuration-provider~=1.0.0
ovos-phal-plugin-dashboard~=0.0.1
ovos-phal-plugin-connectivity-events~=0.0.2
ovos-phal-plugin-connectivity-events~=0.0.3
ovos-phal-plugin-oauth~=0.0.2,>=0.0.3a1
neon-phal-plugin-monitoring~=0.0.1
7 changes: 2 additions & 5 deletions requirements/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
ovos-phal~=0.0.4
ovos-phal~=0.0.4,>=0.0.5a15
neon_utils[network]~=1.6
ovos_utils~=0.0.32
click~=8.0
click-default-group~=1.2
ovos-bus-client~=0.0.4
ovos-bus-client~=0.0.8

# TODO: Patching ovos_PHAL inherited dependencies
ovos_backend_client~=0.0.6
mycroft-messagebus-client~=0.10

0 comments on commit df75056

Please sign in to comment.