Allow overriding the namespace of the orchestrator #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woutersmit
changed the title
woutersmit
force-pushed
the
feature/775-override-namespace-orchestrator
branch
from
bbced78 to
db815cf
Compare
|
Would be nice for us if this PR is merged, can a maintainer please have a look? |
woutersmit
force-pushed
the
feature/775-override-namespace-orchestrator
branch
from
db815cf to
30333c2
Compare
netapp-ci-sync
bot
force-pushed
the
master
branch
from
5ccfdf7 to
94d0bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Allow overriding the namespace of the orchestrator if you need it to be deployed to a namespace other than the namespace the operator is deployed in.
Project tracking
#775
Do any added TODOs have an issue in the backlog?
No
Did you add unit tests? Why not?
No. minor change in helm chart, deploys correctly to private cluster
Does this code need functional testing?
No.
Is a code review walkthrough needed? why or why not?
No.
Should additional test coverage be executed in addition to pre-merge?
No.
Does this code need a note in the changelog?
Yes. e.g.: Allow overriding the namespace of the orchestrator
Does this code require documentation changes?
No
Additional Information