New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: skip future cancellation when not needed #151

Open

jasonk000 wants to merge 1 commit into master from jkoch/skip-cancel

Member

jasonk000 commented Nov 14, 2024 •

edited

Loading

It implicitly throws an expensive exception. Some codepaths throw away the errorFuture, so there is no need to issue the cancel/throw the exception.

This is approximately half of the CPU overhead on the caller thread for the getAsync call.


          perf: skip future cancellation when not needed

b200a51

it implicitly throws an expensive exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet