Enhance log for key size check #153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shy-1234
requested review from
akashdeepgoel,
pkarumanchi9,
samuelfu and
srrangarajan
evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java
Outdated
Show resolved
Hide resolved
evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java
Outdated
Show resolved
Hide resolved
brewsterw
reviewed
Nov 20, 2024
| @@ -215,7 +215,9 @@ EVCacheKey getEVCacheKey(final String key) { | |||
| } | |||
|
|
|||
| if (canonicalKey.length() > this.maxKeyLength.get() && !hashKey.get() && !autoHashKeys.get()) { | |||
| throw new IllegalArgumentException("Key is too long (maxlen = " + this.maxKeyLength.get() + ')'); | |||
| final String errMsg = String.format("CanonicalKey ``%s`` is too long (maxLen = %d, keyLen = %d, canonicalKeyLen = %d)", canonicalKey, this.maxKeyLength.get(), key.length(), canonicalKey.length()); | |||
There was a problem hiding this comment.
is it possible to add the evcache_app that is causing this? the one that is being written to or read from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original error message lacked the information for end users to take action. Also added a log so that the information can still be accessed even when the exception is swallowed.