Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeLimit workflow #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

robvanderleek
Copy link

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes (Please run ./gradlew build --write-locks to refresh dependencies)
  • Other (please describe): Consider code quality tool

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Thanks for this wonderful project.
Are you open to include a simple code quality check in the automated build system?
I'm developing an open source tool called CodeLimit that monitors function length.
Still in active development, looking for any kind of feedback from the community.
The generated report for this codebase is attached below.

CodeLimit Report

Overview

Language Files Lines of Code Functions
Java 439 28797 2473 170 44

Summary

Easy / Verbose Hard-to-maintain ⚠ Unmaintainable ❌
60% 25% 15%

🛑 15% of the functions are unmaintainable, refactoring necessary.

Findings

Function Length File
jjMoveNfa_0 442 netflix-sel/src/main/java/com/netflix/sel/ast/SelParserTokenManager.java
doExecute 143 maestro-engine/src/main/java/com/netflix/maestro/engine/tasks/MaestroTask.java
PrimarySuffix 140 netflix-sel/src/main/java/com/netflix/sel/ast/SelParser.java
execute 135 maestro-engine/src/main/java/com/netflix/maestro/engine/steps/ForeachStepRuntime.java
deriveTypedParameter 121 maestro-common/src/main/java/com/netflix/maestro/utils/ParamHelper.java
jjMoveStringLiteralDfa0_0 108 netflix-sel/src/main/java/com/netflix/sel/ast/SelParserTokenManager.java
onWorkflowFinalized 108 maestro-engine/src/main/java/com/netflix/maestro/engine/listeners/MaestroWorkflowStatusListener.java
getNextToken 102 netflix-sel/src/main/java/com/netflix/sel/ast/SelParserTokenManager.java
ForStatement 101 netflix-sel/src/main/java/com/netflix/sel/ast/SelParser.java
jjStopStringLiteralDfa_0 100 netflix-sel/src/main/java/com/netflix/sel/ast/SelParserTokenManager.java

204 more rows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant