-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ldap): alter external LDAP domains #806
Open
stephdl
wants to merge
15
commits into
main
Choose a base branch
from
sdl-7298
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-external-domain action
…mainConfiguration view
…gle for bind_password field
…removing unused LDAP fields
…tion when multiple providers are present
…tate based on TLS verification
…ainModal and DomainConfiguration
core/imageroot/var/lib/nethserver/cluster/actions/alter-external-domain/50alter_ldap_domain
Outdated
Show resolved
Hide resolved
andre8244
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor label improvement
…conditional rendering based on TLS verification
…al-domain/50alter_ldap_domain Co-authored-by: Davide Principi <[email protected]>
Co-authored-by: Andrea Leardini <[email protected]>
DavidePrincipi
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce scripts to validate domain existence and LDAP provider configuration, along with a JSON schema for input validation. These changes enhance the management of external LDAP domains in the system.
As asked by the NS8 administrator configuration I disable the button to add external provider if tls verify is enabled, same in the modal, I disable the toggle if providers are > 1.
Warning : what about former configuration with multiple providers and tls_verify enabled
NethServer/dev#7298