fix(ldap): Update domain configuration and reload event #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andre8244
reviewed
Feb 14, 2025
| @@ -1049,7 +1050,7 @@ export default { | |||
| } | |||
| this.currentProvider = provider; | |||
|
|
|||
| if (this.domain.schema === "ad") { | |||
| if (this.domain.schema === "ad" && this.domain.location == "internal") { | |||
There was a problem hiding this comment.
Not sure to understand this change 🤔
There was a problem hiding this comment.
simple, we use the internal removal action for an external ldap provider
There was a problem hiding this comment.
Ok, I'm a little rusty on this topic, I trust you and @DavidePrincipi , approving ✔️
andre8244
approved these changes
Feb 14, 2025
DavidePrincipi
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the domain configuration logic for internal Active Directory schemas and emit a reload event after adding an external provider.
NethServer/dev#7315