Build bouncer from Alpine and install from GitHub page #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… container capabilities
DavidePrincipi
requested changes
Feb 10, 2025
There was a problem hiding this comment.
Thank you for the idea, I'd like to restrict the container privileges if possible and I agree to do experiments to find the minimal set of privileges.
However I prefer to let crowdsec-firewall-bouncer create and manage nftables rules rather than handling them explicitly within the project. This approach ensures that the bouncer functions as intended without external modifications, keeping maintenance and compatibility in line with upstream behavior. For this reason, I am rejecting this PR.
|
No way to create directly the nftables rules without to be privileged, so go back to it |
…c-firewall-bouncer
DavidePrincipi
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the base image for the bouncer to Alpine and update the installation method to fetch the binary directly from the GitHub releases page.
NethServer/dev#7307