Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionalities for main function inputs #681

Merged
merged 29 commits into from
Jan 22, 2025
Merged

Add functionalities for main function inputs #681

merged 29 commits into from
Jan 22, 2025

Conversation

MaksymMalicki
Copy link
Contributor

@MaksymMalicki MaksymMalicki commented Jan 12, 2025 •
edited
Loading

No description provided.

MaksymMalicki and others added 19 commits November 15, 2024 16:16
@MaksymMalicki
Fixes for the generation of entry code, fixes of hints parsing
d7b74e6
@MaksymMalicki
Add modifications to the runner
dfd9ec8
@MaksymMalicki
Merge branch 'main' into add_code_entry
a7814a1
@MaksymMalicki
Add fixes for the entrycode generation
83872d8
@MaksymMalicki
Refactor main CLI, offset the hints indexes by entry code size, load …
cd04099 
…arguments and initial gas to the memory
@MaksymMalicki
Add available gas and user args (#677)
5eb27ab 
* Add parsing logic for input user args

* Add flags for available gas, input user args, writing args to memory

* Fix unit tests for user arguments parsing

* Lint the PR

* Add user args to hint context

* Refactor the code

* Fix unconditional append of ExternalWriteArgsToMemory, bug fixes in integration tests

* Add fixes of the call size calculation and include ExternalWriteArgsToMemory hint when gas present

* Add layouts for integration tests

* Add error handling

* Fixes in entry code generation

* Address changes mentioned in a discussion

* Add comment regarding writing to memory in a hint for the future reference in the integration tests with args

* Changes in calculations of the initial PC offset, CALL opcode offset incremented by mainFuncOffset, writing user args to the AP in the hint

* Turn back VM config to private field

* Add error handling on assign of `userArgs` to the initial scope

* Lint project

* Bump go version from 1.20 -> 1.21 (#678)

* Bump go version from 1.20 -> 1.21

* Update golangci-lint

* Simplify the Makefile

* Correction in the makefile
@MaksymMalicki
Fix the integration tests
8812042
@MaksymMalicki
Fixes in the runner
78cf788
@MaksymMalicki
Fixes in the runner
af47a3d
@MaksymMalicki
Fix the unit tests, uncomment pythonVm execution in integration tests…
73f6dd5 
…, code cleanups
@MaksymMalicki
Add writing tokens gas cost to memory
17b17df
@MaksymMalicki
Proper builtins initialization for cairo mode
688b3d2
@MaksymMalicki
Address comments in the PR
f105506
@MaksymMalicki
Fix bugs regarding dicts
cc82938
@MaksymMalicki
Remove prints
a32add7
@MaksymMalicki
Merge branch 'main' into missing_dict_functionalities
07f4016
@MaksymMalicki
Fixes of the last tests for the dicts
53d4190
@MaksymMalicki
Add dict_non_squashed dir to the integration tests
31aeeed
@MaksymMalicki
Add checks for the matching args size, rename files, modify the integ…
086011a 
…ration tests pipeline
@MaksymMalicki MaksymMalicki marked this pull request as draft January 12, 2025 11:39
@MaksymMalicki MaksymMalicki changed the title Add checks for the matching args size, rename files, modify the integ… Add functionalities for main function inputs Jan 12, 2025
Base automatically changed from missing_dict_functionalities to main January 14, 2025 14:16
@MaksymMalicki MaksymMalicki marked this pull request as ready for review January 16, 2025 12:51
cicr99
cicr99 reviewed Jan 16, 2025
View reviewed changes
pkg/hintrunner/core/hint.go Show resolved Hide resolved
integration_tests/cairo_vm_test.go Outdated Show resolved Hide resolved
pkg/hintrunner/hintrunner.go Outdated Show resolved Hide resolved
pkg/hintrunner/hintrunner.go Show resolved Hide resolved
pkg/hintrunner/hintrunner_test.go Outdated Show resolved Hide resolved
pkg/vm/builtins/builtin_runner.go Outdated Show resolved Hide resolved
cicr99
cicr99 reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failing now. I think is the hintrunner_test.go the one having problems. Might have been because of the changes regarding NewHintRunner method?
Also integration tests are also failing.

@cicr99 cicr99 merged commit 5ada20b into main Jan 22, 2025
6 checks passed
@cicr99 cicr99 deleted the inputs branch January 22, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicr99 cicr99 cicr99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MaksymMalicki @cicr99