Apply suggestions from code review

Co-authored-by: Marc <[email protected]>
NethermindEth · Oct 15, 2024 · 5a07992 · 5a07992
1 parent 1197d1c
commit 5a07992
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/libp2p/Libp2p.Core/Discovery/PeerStore.cs b/src/libp2p/Libp2p.Core/Discovery/PeerStore.cs
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-FileCopyrightText: 2024 Demerzel Solutions Limited
 // SPDX-License-Identifier: MIT
 
 using Google.Protobuf;

diff --git a/src/libp2p/Libp2p.Protocols.MDns/MDnsDiscoveryProtocol.cs b/src/libp2p/Libp2p.Protocols.MDns/MDnsDiscoveryProtocol.cs
@@ -18,9 +18,9 @@ public class MDnsDiscoveryProtocol(PeerStore peerStore, ILoggerFactory? loggerFa
 
     public static string Id => "mdns";
 
-    private readonly string ServiceName = "_p2p._udp.local";
+    private const string ServiceName = "_p2p._udp.local";
 
-    private readonly string? ServiceNameOverride = "pubsub-chat-example";
+    private const string? ServiceNameOverride = "pubsub-chat-example";
 
     private string PeerName = null!;
 

diff --git a/src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.Topics.cs b/src/libp2p/Libp2p.Protocols.Pubsub/PubsubRouter.Topics.cs
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: 2023 Demerzel Solutions Limited
+// SPDX-FileCopyrightText: 2024 Demerzel Solutions Limited
 // SPDX-License-Identifier: MIT
 
 using Nethermind.Libp2p.Core;
@@ -118,7 +118,7 @@ public void Publish(string topicId, byte[] message)
         topicState.GetOrAdd(topicId, (id) => new Topic(this, topicId));
 
         ulong seqNo = this.seqNo++;
-        byte[] seqNoBytes = new byte[8];
+        byte[] seqNoBytes = stackalloc byte[8];
         BinaryPrimitives.WriteUInt64BigEndian(seqNoBytes, seqNo);
         Rpc rpc = new Rpc().WithMessages(topicId, seqNo, localPeer!.Address.GetPeerId()!.Bytes, message, localPeer.Identity);