Add session #92
Merged
Add session #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flcl42
commented
Aug 20, 2024
flcl42
commented
- Add transport, connection, session context
- Separate connection instantiation
- Make protocol builder more flexible
- Handle more in local peer impl, merging factoring into it
16 tasks
Marchhill
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Seems to be running well on Chiado atm. Generally found the code quite hard to read, codebase could do with a cleanup to put classes and interfaces into own files, break up large classes / functions, handle specific exceptions, more comments / more self-documenting code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.