Reuse rpcv6 BlockHeader for v7 and v8 #2448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clean rpc pkgs according to issue #2437
Header
is the same as v6, so, i just removed it and reused v6's entirely.Header
just has one more fieldL2GasPrice
. So, I embedded rpcv6.Header into rpcv8.Header. Let me know whether it is ok to do that. I thought it could be nice as it reuses v6's Header and reduces code dup and makes it clear what new fields have been added, but when instantiating a v8 Header, we have to define an rpcv6 Header field inside, so it might be a bit strange maybe? ie:And also, as you can see in the tests (in file
subscriptions_test.go
) that i had to fix, it changes the order of the fields in the stringified json. Could that be an issue ? I don't think so but still asking to make sure it's fine!