Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use INSUFFICIENT_RESOURCES_FOR_VALIDATE instead of INSUFFICIENT_MAX_FEE in v8 #2457

Merged
merged 5 commits into from
Feb 17, 2025

Conversation

hudem1
Copy link
Contributor

@hudem1 hudem1 commented Feb 11, 2025

Solves issue #2391

Note: In the rpccore.go file, now the 2 errors INSUFFICIENT_MAX_FEE and INSUFFICIENT_RESOURCES_FOR_VALIDATE have the same code (53), but they are never both used in the same pkg

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.76%. Comparing base (00168b1) to head (6c6034f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2457      +/-   ##
==========================================
+ Coverage   73.66%   73.76%   +0.10%     
==========================================
  Files         138      138              
  Lines       16919    16918       -1     
==========================================
+ Hits        12463    12480      +17     
+ Misses       3587     3574      -13     
+ Partials      869      864       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

clients/gateway/gateway.go Outdated Show resolved Hide resolved
rpc/rpccore/rpccore.go Outdated Show resolved Hide resolved
clients/gateway/gateway.go Outdated Show resolved Hide resolved
rpc/v8/transaction.go Show resolved Hide resolved
@rodrigo-pino rodrigo-pino merged commit 2fc5f61 into main Feb 17, 2025
14 checks passed
@rodrigo-pino rodrigo-pino deleted the hudem1/insufficient-resources-for-validate branch February 17, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants