-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Nethermind executable name #5908
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jul 7, 2023
rubo
force-pushed
the
feature/unified-exec-name
branch
from
July 8, 2023 10:09
1352b8b
to
c957d4a
Compare
rubo
force-pushed
the
feature/unified-exec-name
branch
from
July 23, 2023 19:47
dc26a33
to
b6d214c
Compare
qu0b
added a commit
to antithesishq/ethereum-testnet-bootstrapper
that referenced
this pull request
Aug 4, 2023
executable name change NethermindEth/nethermind#5908
qu0b
added a commit
to antithesishq/ethereum-testnet-bootstrapper
that referenced
this pull request
Aug 4, 2023
executable name change NethermindEth/nethermind#5908
16 tasks
This was referenced Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR unifies the Nethermind executable name as now it's different depending on the installation source. For PPA and Homebrew, it's
nethermind
while for manual downloads it'sNethermind.Runner
. The same issue is with the launcher and CLI.Nethermind.Runner
tonethermind
Nethermind.Cli
tonethermind-cli
Nethermind.Launcher
tonethermind-launcher
Nethermind.Runner
symlink for Linux packages to support the old naming for any existing setupBefore release
After release
Update docsUpdate Nethermind executable name dappnode/DAppNodePackage-nethermind#155
Update Nethermind executable name dappnode/DAppNodePackage-nethermind-xdai#105
Update Nethermind executable name dappnode/DAppNodePackage-goerli-nethermind#46
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Needs manual testing.
Documentation
Requires documentation update
#5961
Requires explanation in Release Notes
The warning to include in all releases in the upcoming months:
After a few months, the above warning should be removed
together with the symlinks.