porting builder changes - code compiles #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowosie
force-pushed
the
pnowosie/add_fb_builder
branch
from
a63f687 to
13d32d5
Compare
pnowosie
commented
Nov 17, 2023
| @@ -278,6 +279,12 @@ func NewServer(config *Config, opts ...serverOption) (*Server, error) { | |||
| } | |||
| } | |||
|
|
|||
| if config.Builder.Enabled { | |||
| if err := builder.Register(stack, srv.backend, config.Builder); err != nil { | |||
There was a problem hiding this comment.
This is where builder is attached to the node, here we call builder's service Register method.
Register do a bunch of initialisation but important is it configures and starts CliqueBuilder
At the very end of the Register we register BuilderService which implements Lifecycle interface into the stack.
Lifecycle exposes 2 methods where important is Start which calls our
CliqueBuilder.Start method.
In Start builder subscribe its channel to the HeadEvent and starts listening on new events calling onChainHeadEvent method which finally spins up new goroutine with runBuildingJob
Here I will leave the further investigation as it's mostly builder related black magic inside runRetryLoop
pnowosie
force-pushed
the
pnowosie/add_fb_builder
branch
from
88ae219 to
9a18a92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very painful & long effort to make bor a builder 👷♂️