fix: should detect account class automatically #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liam-nethermind
approved these changes
Jul 18, 2024
julio4
reviewed
Jul 19, 2024
Yes, the account class detection has always been done in the backend. We're simply removing this since we don't use this param in the backend anymore and can detect it via indexers now. |
|
Do not merge this, should only be merged when https://github.com/NethermindEth/voyager/pull/5363 is merged. |
cwkang1998
force-pushed
the
fix/should-not-ask-for-is-account
branch
from
5345ab4 to
e20630c
Compare
cwkang1998
force-pushed
the
fix/should-not-ask-for-is-account
branch
from
e20630c to
470fddc
Compare
julio4
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per title, should detect account class automatically and do not ask in the prompt in the CLI.
Closes #48