-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve path error and improve versioning error #57
Conversation
Hey, is there a ticket for this already opened? If not can you either open a ticket for this on github or if the ticket only exists on our taskboard on notion can you point me to it so I can copy / move it here? |
resolve path error - #42 |
@liam-nethermind seems that your commits are unverified, is it possible to resign them? Minor issues, but will be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Versioning error seems to display nicely now, however testing it on my side on the tilda related issue seems to have resurfaced / regressed.
❯ cargo run --bin starknet-contract-verifier
Finished dev [unoptimized + debuginfo] target(s) in 0.26s
Running `target/debug/starknet-contract-verifier`
[1/4] 📝 Getting project information...
✔ Enter Path to scarb project root: · ~/testing
[2/4] 🔗 Resolving project...
error: failed to read manifest at: /Users/chen/Projects/nethermind/starknet-contract-verifier/~/testing/Scarb.toml
@cwkang1998 Fixed. Can you review it again? |
Closes #23, #59