Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve path error and improve versioning error #57

Merged
merged 5 commits into from
Aug 2, 2024

Conversation

liam-nethermind
Copy link
Contributor

@liam-nethermind liam-nethermind commented Jul 23, 2024

Closes #23, #59

@liam-nethermind liam-nethermind self-assigned this Jul 23, 2024
@liam-nethermind liam-nethermind added the bug Something isn't working label Jul 23, 2024
@cwkang1998
Copy link
Contributor

Hey, is there a ticket for this already opened? If not can you either open a ticket for this on github or if the ticket only exists on our taskboard on notion can you point me to it so I can copy / move it here?

@cwkang1998 cwkang1998 changed the title Fix: resolve path error and improve versioning error fix: resolve path error and improve versioning error Jul 23, 2024
@NethermindEth NethermindEth deleted a comment from mstrong-tech Jul 23, 2024
@liam-nethermind
Copy link
Contributor Author

liam-nethermind commented Jul 23, 2024

Hey, is there a ticket for this already opened? If not can you either open a ticket for this on github or if the ticket only exists on our taskboard on notion can you point me to it so I can copy / move it here?

resolve path error - #42
improve versioning error - #59 or #23 (not sure it's the same case)

@cwkang1998
Copy link
Contributor

@liam-nethermind seems that your commits are unverified, is it possible to resign them? Minor issues, but will be great.

Copy link
Contributor

@cwkang1998 cwkang1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning error seems to display nicely now, however testing it on my side on the tilda related issue seems to have resurfaced / regressed.

❯ cargo run --bin starknet-contract-verifier
    Finished dev [unoptimized + debuginfo] target(s) in 0.26s
     Running `target/debug/starknet-contract-verifier`
[1/4] 📝 Getting project information...
✔ Enter Path to scarb project root: · ~/testing
[2/4] 🔗 Resolving project...
error: failed to read manifest at: /Users/chen/Projects/nethermind/starknet-contract-verifier/~/testing/Scarb.toml

@liam-nethermind
Copy link
Contributor Author

@cwkang1998 Fixed. Can you review it again?

@cwkang1998 cwkang1998 merged commit f523a27 into main Aug 2, 2024
4 checks passed
@cwkang1998 cwkang1998 deleted the fix-resolve-path-and-improve-errors branch August 2, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't work when running as explained in instructions
3 participants