Universal tool rewrite #80
Conversation
Also wrap most options in newtype wrapper and parse them instead of validating. Right now the network selection is as Subcommand but that should be implemented using ValueEnum.
Made api module use the type defined in the args instead of the custom one.
Seems much cleaner than concatenating string. Additionally retry with exponential back off, by the way of external dependency. Still there are 2 possible clients, public and private and not all endpoints are available at both, but this is going to ba tackled in the future.
This lets us use this later without worrying and error checking.
GitHub workflows that were placeholders, config files for tools that weren't used.
|
In the README.md, can you please add a "Quick Start" section, with steps and CLI command examples to illustrate the verification process? |
Also sneak in the license name mapping for our current backend.
| - [x] Cairo 2.8.2 & Scarb 2.8.2 | ||
| - [x] Cairo 2.8.2 & Scarb 2.8.3 | ||
| - [x] Cairo 2.8.4 & Scarb 2.8.4 | ||
| Contract verifier works with [Scarb](https://docs.swmansion.com/scarb) based projects. The tool assumes that `scarb` command is available in the envirenment and project is building properly by executing `scarb bulid`. |
There was a problem hiding this comment.
It would be useful to know which versions are currently supported by the backend, or at least what is the latest supported version
There was a problem hiding this comment.
That one is a bit tricky I think. The exact supported versions are defined by the backend and mentioning it here will surely lead to misleading information down the line. In any case if the version is not yet supported by the backend, we get ok error messae saying that it's not supported
| @@ -88,87 +25,69 @@ sierra = true | |||
|
|
|||
| # Add the following section | |||
| [tool.voyager] | |||
| my_contract = { path = "main.cairo" } | |||
| my_contract = { path = "src/main.cairo" } | |||
There was a problem hiding this comment.
It's important to add here that my_contract MUST match the actual name of the contract in the project
This basically rewrites the cli to be much simpler, hence making it work independent of the scrab/cairo version. It achieves that by changing how we gather files to be sent to the backend. Instead of using scarb as a library it utilizes scarb metadata and gathers all the files, plus the files of the local dependencies.
Other major change is that the application is no longer interactive, but all the parameters are passed as an command line arguments.