Skip to content

Commit

Permalink
New logic for plot limits (#48)
Browse files Browse the repository at this point in the history
* Updates the PR according to the presence of robust_t novel function in neo_utils

* Adding "None" as a permitted value in all plotting scripts

* Minor change in config template files

* Fix for extra spacings added when merging PR #61
  • Loading branch information
cosimolupo authored Jul 18, 2024
1 parent 364ddd5 commit 9bc48f4
Show file tree
Hide file tree
Showing 12 changed files with 30 additions and 28 deletions.
4 changes: 2 additions & 2 deletions cobrawap/pipeline/configs/config_template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ NEO_FORMAT: 'nix'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
# Note that when using the None option, the automatic creation of reports will fail
PLOT_FORMAT: 'png'
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ KWARGS: 'None'
# Plotting parameters
# These parameters are used to create an example plot to get a first view
# on the signals and ensure that the data was loaded and annotated correctly
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int, or list of int, or 'None' -> randomly chosen channel
PLOT_FORMAT: 'png' # file extension for storing the plot
10 changes: 5 additions & 5 deletions cobrawap/pipeline/stage01_data_entry/scripts/plot_traces.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@
import seaborn as sns
from utils.io_utils import load_neo, save_plot
from utils.neo_utils import time_slice
from utils.parse import parse_plot_channels, none_or_int
from utils.parse import parse_plot_channels, none_or_int, none_or_float

CLI = argparse.ArgumentParser()
CLI.add_argument("--data", nargs='?', type=Path, required=True,
CLI.add_argument("--data", nargs='?', type=Path, required=True,
help="path to input data in neo format")
CLI.add_argument("--output", nargs='?', type=Path, required=True,
CLI.add_argument("--output", nargs='?', type=Path, required=True,
help="path of output figure")
CLI.add_argument("--t_start", nargs='?', type=float, default=0,
CLI.add_argument("--t_start", nargs='?', type=none_or_float, default=0,
help="start time in seconds")
CLI.add_argument("--t_stop", nargs='?', type=float, default=10,
CLI.add_argument("--t_stop", nargs='?', type=none_or_float, default=10,
help="stop time in seconds")
CLI.add_argument("--channels", nargs='+', type=none_or_int, default=0,
help="list of channels to plot")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ NEO_FORMAT: 'nix'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
help="overlap parameter for Welch's algorithm [0-1]")
CLI.add_argument("--fft_slice", nargs='?', type=none_or_float, default=None,
help="time window length used for power spectrum estimate, in s")
CLI.add_argument("--plot_tstart", nargs='?', type=float, default=0,
CLI.add_argument("--plot_tstart", nargs='?', type=none_or_float, default=0,
help="start time in seconds")
CLI.add_argument("--plot_tstop", nargs='?', type=float, default=10,
CLI.add_argument("--plot_tstop", nargs='?', type=none_or_float, default=10,
help="stop time in seconds")
CLI.add_argument("--plot_channels", nargs='+', type=none_or_int, default=None,
help="list of channels to plot")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,21 @@
import os
from utils.io_utils import load_neo, save_plot
from utils.neo_utils import time_slice
from utils.parse import none_or_float

CLI = argparse.ArgumentParser()
CLI.add_argument("--original_data", nargs='?', type=str, required=True,
help="path to input data in neo format")
CLI.add_argument("--data", nargs='?', type=str, required=True,
help="path to input data in neo format")
CLI.add_argument("--img_dir", nargs='?', type=str, required=True,
CLI.add_argument("--img_dir", nargs='?', type=str, required=True,
help="path of output figure directory")
CLI.add_argument("--img_name", nargs='?', type=str,
default='processed_trace_channel0.png',
help='example filename for channel 0')
CLI.add_argument("--t_start", nargs='?', type=float, default=0,
CLI.add_argument("--t_start", nargs='?', type=none_or_float, default=0,
help="start time in seconds")
CLI.add_argument("--t_stop", nargs='?', type=float, default=10,
CLI.add_argument("--t_stop", nargs='?', type=none_or_float, default=10,
help="stop time in seconds")
CLI.add_argument("--channels", nargs='+', type=int, default=0,
help="channel to plot")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ NEO_FORMAT: 'nix'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ NEO_FORMAT: 'nix'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,16 @@
import quantities as pq
from utils.io_utils import load_neo, write_neo
from utils.neo_utils import time_slice
from utils.parse import none_or_float

CLI = argparse.ArgumentParser()
CLI.add_argument("--data", nargs='?', type=str, required=True,
help="path to input data in neo format")
CLI.add_argument("--output", nargs='?', type=str, required=True,
help="path of output file")
CLI.add_argument("--t_start", nargs='?', type=float, default=0,
CLI.add_argument("--t_start", nargs='?', type=none_or_float, default=0,
help="new starting time in s")
CLI.add_argument("--t_stop", nargs='?', type=float, default=10,
CLI.add_argument("--t_stop", nargs='?', type=none_or_float, default=10,
help="new stopping time in s")

if __name__ == '__main__':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ STAGE_OUTPUT: 'channel-wise_measures.csv'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ STAGE_OUTPUT: 'wave-wise_measures.csv'
USE_LINK_AS_STAGE_OUTPUT: True

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ OFFSET: 20
A: 'a'

# Plotting parameters
PLOT_TSTART: 0 # in s
PLOT_TSTOP: 10 # in s
PLOT_TSTART: 0 # float (in s) or 'None' -> starting time of the input signal is used
PLOT_TSTOP: 10 # float (in s) or 'None' -> stopping time of the input signal is used
PLOT_CHANNELS: 'None' # int or None. default 'None' -> randomly selected
PLOT_FORMAT: 'png'

0 comments on commit 9bc48f4

Please sign in to comment.