Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] use warnings with logging in elephant.utils.round_binning_errors #571

Merged
merged 4 commits into from
Oct 25, 2023
Merged

[ENH] use warnings with logging in elephant.utils.round_binning_errors #571

merged 4 commits into from
Oct 25, 2023

Conversation

Moritz-Alexander-Kern
Copy link
Member

@Moritz-Alexander-Kern Moritz-Alexander-Kern commented Jun 2, 2023 •
edited
Loading

This PR aims to suggest a solution to Issue #567 .

The warnings in function round_binning_errors() from elephant/utils.py are replaced by log calls.

t.b.d.

  • decide on loglevel, e.g. logging.warning ? loglevel: warning
  • default log level for the logger: not_set

@Moritz-Alexander-Kern Moritz-Alexander-Kern linked an issue Jun 2, 2023 that may be closed by this pull request
Remove annoying warnings #567
Closed
@Moritz-Alexander-Kern Moritz-Alexander-Kern mentioned this pull request Jun 2, 2023
Merged
@coveralls
Copy link
Collaborator

coveralls commented Jun 2, 2023 •
edited
Loading

Coverage Status

coverage: 86.677% (+0.01%) from 86.667% when pulling 5a698de on INM-6:enh/logging_utils into 5b464ec on NeuralEnsemble:master.

@Moritz-Alexander-Kern Moritz-Alexander-Kern marked this pull request as ready for review June 6, 2023 07:35
@Moritz-Alexander-Kern Moritz-Alexander-Kern added the enhancement Editing an existing module, improving something label Jul 3, 2023
@Moritz-Alexander-Kern Moritz-Alexander-Kern added this to the v0.14.0 milestone Sep 18, 2023
Moritz-Alexander-Kern
Moritz-Alexander-Kern commented Sep 20, 2023
View reviewed changes
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern changed the title [ENH] replace warnings with logging to elephant.utils.round_binning_errors [ENH] use warnings with logging in elephant.utils.round_binning_errors Sep 20, 2023
mdenker
mdenker requested changes Oct 25, 2023
View reviewed changes
elephant/utils.py Outdated Show resolved Hide resolved
elephant/utils.py Outdated Show resolved Hide resolved
Moritz-Alexander-Kern and others added 2 commits October 25, 2023 10:29
@Moritz-Alexander-Kern @mdenker
Update elephant/utils.py
23f732c 
Co-authored-by: Michael Denker <[email protected]>
@Moritz-Alexander-Kern @mdenker
Update elephant/utils.py
7c2390a 
Co-authored-by: Michael Denker <[email protected]>
Moritz-Alexander-Kern
Moritz-Alexander-Kern commented Oct 25, 2023
View reviewed changes
Copy link
Member Author

@Moritz-Alexander-Kern Moritz-Alexander-Kern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build wheels

@Moritz-Alexander-Kern Moritz-Alexander-Kern merged commit 9a07224 into NeuralEnsemble:master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdenker mdenker mdenker requested changes

@morales-gregorio morales-gregorio Awaiting requested review from morales-gregorio

Assignees
No one assigned
Labels
enhancement Editing an existing module, improving something
Projects
None yet
Milestone
v0.14.0
Development

Successfully merging this pull request may close these issues.

Remove annoying warnings
3 participants
@Moritz-Alexander-Kern @coveralls @mdenker