-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loader to accept non-strings #80
Conversation
etree is old and so doesn't accept py3.4's `pathlib.Path`. parsexml_ now calls `str()` on non-strings to work around this and other similar `os.PathLike`s.
This has been rebased on #81 to fix the 3.5 failure. |
Hmm. Is this PR even mergeable, as |
Thanks for these changes @clbarnes, i'll look at them over the next few days. An update to the version of generateDS might solve some of the problems.. Alternatively a small script for a standard search/replace to post process the nml.py should suffice, with instructions added here: https://github.com/NeuralEnsemble/libNeuroML/blob/development/neuroml/nml/README.md. |
Thanks, I'll look into that. I think my commits are all in the wrong order now I've realised editing |
Just FYI I have raised a PR on generateds which should allow this the next time the code is regenerated. |
The generateds PR has been merged https://bitbucket.org/dkuhlman/generateds/commits/8ee5214bd106 , don't know when it'll make it into a release though. |
Thanks @clbarnes. Have tested the latest generateDS locally with libNeuroML and it looks like it works fine. Will check through your other changes as soon as I get a chance. |
Worth noting that the changes to generateDS will only allow it to work with |
etree is old and so doesn't accept py3.4's
pathlib.Path
.parsexml_ now calls
str()
on non-strings to work around this and othersimilar
os.PathLike
s.