Changes for NML v2.3 release #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more performant than having a Marker object for each sphere. Ideally, we should also use a single Line object to plot all lines in the same way, to improve performance. A TODO.
test(modchananalysis): test to check that nrnivmodl is run when required
* development: (23 commits) ci: also run `pynml` multi-validation chore(pynml): format with black Adding logic for one-shot validation of multiple input files feat: improve installation of extra deps feat(plot-morph): add different types to 2d/3d plots chore: use logger test(utils): add test for `extract_position_info` test: add example L23 cell network for tests test(plotter): add test for plotting network of cells chore: clean imports, use logger chore: remove unused import fix(pynml): correctly handle mutable arguments fix(pynml): correct location of debug statement fix(pynml): correct conditional chore: bump copyright year to 2023 ci(py311): add py311 to ci and setup.py chore: update copyright year chore(archive): format with black fix(archive-tests): ensure new variable is passed to each call fix(archive): clean up temp dir after processing ...
* development: chore(gitignore): ignore `*.neux` fix: only test validation of valid files
…rimental * 'experimental' of github.com:NeuroML/pyNeuroML: Ignore arm64 dir on new mac chip
pynml-modchananalysis excepting on division by zero
…rimental * 'experimental' of github.com:NeuroML/pyNeuroML: test(modchananalysis): test to check that nrnivmodl is run when required ooops, had forgotten to commit right logic handling near zero values Checking for compiled mod files. Fixes #165
feat(pynml): include more info in version
Just needed to replace it with sympy's `Heaviside` function: Reference: https://docs.sympy.org/latest/modules/functions/special.html#sympy.functions.special.delta_functions.Heaviside
Feat/chan den analysis
Feat/nsgr integration
Generate pngs of tests in same dirs
One can provide what fraction of each population should be plotted as a point neuron.
To v1.1.0; Update to jnml v0.12.3 jar
To v1.1.0; uses jnml jar 0.12.4
feat(write): include HDF5 writing
Feat/hybrid plots: allow users to specify how they want various cells in networks to be plotted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.