Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory usage when generating morph plots and a few minor fixes #258

Merged
merged 6 commits into from
Sep 21, 2023
Merged

Reduce memory usage when generating morph plots and a few minor fixes #258

merged 6 commits into from
Sep 21, 2023

Conversation

sanjayankur31
Copy link
Member

  • pop dict items as they are consumed to limit memory requirements
  • fix minor bug in plot title generation
  • quietly skip included files if they cannot be found during plot generation from Cell/NeuroMLDocument objects; when a file is passed, we are able to figure out where the includes are relative to the file, but not when the user passes a Cell/NeuroMLDocument object, where we assume they've loaded things correctly

sanjayankur31 and others added 6 commits September 20, 2023 19:27
@sanjayankur31
perf(plotting): use popitem for iteration
21a6276 
In the plotting, we're only iterating over the items of dicts once and
never using them again. So, there is no reason for us to keep the items
in memory. Instead, we can pop them after we process them.
@pgleeson
Merge pull request #257 from NeuroML/development
b365cd3 
 Changes for NML v2.3 release
@sanjayankur31
fix(morph-plots): only load inc files if they're found
bd42d8a
@sanjayankur31
fix(morph-plots): correct title generation
a222407
@sanjayankur31
chore(plots): print number of cells being plotted
c07f446
@sanjayankur31
Merge branch 'master' into feat/hybrid-plots
286940c
@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement T: bug Type: bug labels Sep 20, 2023
@sanjayankur31 sanjayankur31 changed the base branch from master to development September 21, 2023 10:11
@sanjayankur31 sanjayankur31 merged commit 5d3b17a into development Sep 21, 2023
5 checks passed
@sanjayankur31 sanjayankur31 deleted the feat/hybrid-plots branch September 21, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
T: bug Type: bug T: enhancement Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanjayankur31 @pgleeson