Make neurons from Decision Making tutorial much faster with GraphDynamics #484
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this does away with the composite events for the LIFExci and LIFInh neurons, and the connection-based events that I was originally using, in favour of a new concept where each event is given an object
foreach_connected_neuron
which can be used to apply a function to every downstream connected neuron from a given neuron.This turns out to be much faster than what I was doing before. For example, before I had something like
vs after:
This PR requires Neuroblox/GraphDynamics.jl#10 and Neuroblox/GraphDynamics.jl#9 which should be on the general registry as v0.2.0 soon.
Edit: