implement id for group/dataset as a string #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #36
In h5py, the id property of a group/dataset is an object that exposes low-level operations specific to the HDF5 library. LINDI aims to override the high-level methods such that the low-level operations on id are not needed. However, sometimes packages (e.g., pynwb) use the id as a unique identifier for purposes of caching. Therefore, we make the id to be a string that is unique for each object. If any of the low-level operations are attempted on this id string, then an exception will be raised, which will usually indicate that one of the high-level methods should be overridden.
With this PR, the id is a unique identifier that is specific to (a) the file object and (b) the name/path of the object within the file.