-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support dicts in reference file system for json files #40
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 82.44% 82.55% +0.10%
==========================================
Files 25 25
Lines 1692 1708 +16
==========================================
+ Hits 1395 1410 +15
- Misses 297 298 +1 ☔ View full report in Codecov by Sentry. |
Awesome! |
This looks good to me. It seems like the JSONs are converted to string for the store representation and then converted back to JSON at the end of |
I wanted to preserve the idea that all the files in the reference file system can actually be thought of as files with real byte array content. If we find there is a performance advantage of skipping the round-trip we can revisit. |
With this, the LindiReferenceFileSystemStore supports dicts as proposed in fsspec/filesystem_spec#1562
Also, the
to_reference_file_system()
methods automatically convert all of the.zattrs
,.zgroup
, and.zarray
files into dicts.Also, Neurosift UI now already supports this update.
@rly @bendichter @oruebel