Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement chunks property #44

Merged
merged 2 commits into from
Apr 16, 2024
Merged

implement chunks property #44

merged 2 commits into from
Apr 16, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Apr 12, 2024

implementing chunks property for datasets and using that for recursive copy.

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.22%. Comparing base (f9c449d) to head (b43b67a).

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyDataset.py 28.57% 5 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyFile.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   82.44%   82.22%   -0.23%     
==========================================
  Files          25       25              
  Lines        1692     1699       +7     
==========================================
+ Hits         1395     1397       +2     
- Misses        297      302       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry for the delay.

@magland magland merged commit 0edd1bc into main Apr 16, 2024
6 checks passed
@magland magland deleted the chunks-property branch April 16, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants