Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to dtype when kind is 'O' #47

Merged
merged 4 commits into from
Apr 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion lindi/LindiH5pyFile/LindiH5pyDataset.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,26 @@ def dtype(self):
# return StrDataset(h5obj, None)
# return h5obj
# We cannot have a dtype with kind 'O' and no metadata
ret = np.dtype(str(ret), metadata={})
# There is also this section in pynwb validator.py
# if isinstance(received, np.dtype):
# if received.char == 'O':
# if 'vlen' in received.metadata:
# received = received.metadata['vlen']
# else:
# raise ValueError("Unrecognized type: '%s'" % received)
# received = 'utf' if received is str else 'ascii'
# elif received.char == 'U':
# received = 'utf'
# elif received.char == 'S':
# received = 'ascii'
# else:
# received = received.name
# ------------------------------------------
# I don't know how to figure out when vlen should be str or bytes
# but validate seems to work only when I put in vlen = bytes
#
vlen = bytes
ret = np.dtype(str(ret), metadata={'vlen': vlen})
return ret

@property
Expand Down