Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement templates for reference file system #51

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

magland
Copy link
Collaborator

@magland magland commented Apr 19, 2024

Implements the use of templates in reference file system as in fsspec, but does not support the full jinja2 templating.

For example,

{
    "templates": {"u1": "https://some/url", "u2": "https://some/other/url"},
    "refs": {
        ... "/some/key/0": [
            "{{u1}}" 0, 100
        ],
        ...
    }
}

In this case, the "{{u1}}" will be replaced with the value of the "u1" template string.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.66667% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.55%. Comparing base (bc71a9d) to head (d47fd19).

Files Patch % Lines
lindi/LindiH5pyFile/LindiH5pyFile.py 0.00% 2 Missing ⚠️
...ndi/LindiH5pyFile/LindiReferenceFileSystemStore.py 96.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   82.33%   82.55%   +0.21%     
==========================================
  Files          25       25              
  Lines        1715     1748      +33     
==========================================
+ Hits         1412     1443      +31     
- Misses        303      305       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magland magland merged commit 5cd5d6f into main Apr 19, 2024
6 checks passed
@magland magland deleted the rfs-templates branch April 19, 2024 15:59
@bendichter bendichter mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants