Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove case of LindiH5pyFile wrapping h5py.File #52

Merged
merged 6 commits into from
Apr 19, 2024
Merged

Conversation

magland
Copy link
Collaborator

@magland magland commented Apr 19, 2024

As discussed with Ryan.

For now this is set to merge into dev5 which contains some other pending PRs. Will switch to base of main once those are merged.

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 78.89908% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 83.42%. Comparing base (5cd5d6f) to head (9882980).

Files Patch % Lines
...indi/LindiH5pyFile/writers/LindiH5pyGroupWriter.py 41.66% 7 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyAttributes.py 76.47% 4 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyGroup.py 87.09% 4 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyDataset.py 89.65% 3 Missing ⚠️
lindi/LindiH5pyFile/LindiH5pyFile.py 76.92% 3 Missing ⚠️
...di/LindiH5pyFile/writers/LindiH5pyDatasetWriter.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
+ Coverage   82.59%   83.42%   +0.83%     
==========================================
  Files          28       28              
  Lines        2005     1907      -98     
==========================================
- Hits         1656     1591      -65     
+ Misses        349      316      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magland magland changed the base branch from dev5 to main April 19, 2024 16:01
@magland magland merged commit 95e3fba into main Apr 19, 2024
6 checks passed
@magland magland deleted the no-wrap-h5py branch April 19, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants