Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Only embed specs/namespaces for types that are included in NWB file on export #615

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
+424 −47

Update read_indexed_column.m

ab79e41
Select commit
Loading
Failed to load commit list.
Open

Change: Only embed specs/namespaces for types that are included in NWB file on export #615

Update read_indexed_column.m
ab79e41
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 22, 2025 in 0s

95.19% (target 90.00%)

View this Pull Request on Codecov

95.19% (target 90.00%)

Details

Codecov Report

Attention: Patch coverage is 92.68293% with 9 lines in your changes missing coverage. Please review.

Project coverage is 95.19%. Comparing base (ab53589) to head (ab79e41).

Files with missing lines Patch % Lines
+io/+internal/+h5/mustBeH5File.m 55.55% 4 Missing ⚠️
+io/+internal/+h5/mustBeH5FileReference.m 66.66% 2 Missing ⚠️
+io/+internal/+h5/resolveFileReference.m 87.50% 1 Missing ⚠️
+schemes/+utility/listNwbTypeHierarchy.m 87.50% 1 Missing ⚠️
NwbFile.m 96.87% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #615      +/-   ##
==========================================
+ Coverage   95.18%   95.19%   +0.01%     
==========================================
  Files         124      137      +13     
  Lines        5045     5165     +120     
==========================================
+ Hits         4802     4917     +115     
- Misses        243      248       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov