New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor Flask III] Break up top-level #796

Closed

CodyCBakerPhD wants to merge 14 commits into swap_try_except_to_decorator from rebase_flask_refactor

Collaborator

CodyCBakerPhD commented May 24, 2024

replaces #791


          rebase PR to new organization; continue making updates

d81a72d

CodyCBakerPhD self-assigned this

CodyCBakerPhD and others added 6 commits

May 24, 2024 12:46


          Merge branch 'main' into rebase_flask_refactor

2dec673


          split top-levle into distinct submodules

43e1614


          Merge branch 'rebase_flask_refactor' of https://github.com/neurodataw…

ff081f8

…ithoutborders/nwb-guide into rebase_flask_refactor


          restore frontend changes

518bc10


          alter dandi endpoint call

3620d65


          [pre-commit.ci] auto fixes from pre-commit.com hooks

8467a27

for more information, see https://pre-commit.ci

CodyCBakerPhD commented

View reviewed changes

src/electron/renderer/src/stories/preview/Neurosift.js Show resolved Hide resolved

CodyCBakerPhD commented

View reviewed changes

src/pyflask/apis/_system.py Outdated Show resolved Hide resolved

CodyCBakerPhD commented

View reviewed changes

src/pyflask/apis/_system.py Outdated Show resolved Hide resolved

CodyCBakerPhD commented

View reviewed changes

src/pyflask/apis/data.py Show resolved Hide resolved

CodyCBakerPhD commented

View reviewed changes

src/pyflask/app.py Show resolved Hide resolved

CodyCBakerPhD commented

View reviewed changes

src/pyflask/tests/conftest.py Outdated Show resolved Hide resolved

CodyCBakerPhD and others added 3 commits

May 24, 2024 13:53


          Update src/pyflask/tests/conftest.py

18b7229


          debugging

c70954e


          Merge branch 'rebase_flask_refactor' of https://github.com/neurodataw…

b54df9f

…ithoutborders/nwb-guide into rebase_flask_refactor

CodyCBakerPhD marked this pull request as ready for review

May 24, 2024 18:50

Collaborator Author

CodyCBakerPhD commented May 24, 2024

Ok this is enough for a first PR

@garrettmflynn Let me know if anything looks off

CodyCBakerPhD requested a review from garrettmflynn

May 24, 2024 18:51

CodyCBakerPhD changed the title ~~Refactor and document Flask endpoints~~ Refactor and document Flask endpoints I

CodyCBakerPhD changed the title ~~Refactor and document Flask endpoints I~~ [Refactor Flask I] break up top-level

CodyCBakerPhD changed the title ~~[Refactor Flask I] break up top-level~~ [Refactor Flask I] Break up top-level

Collaborator Author

CodyCBakerPhD commented May 24, 2024

Hmm.. Looks like the module is missing in the PyInstaller build

CodyCBakerPhD added 2 commits

May 25, 2024 13:50


          adjust frontend endpoints to new namespace; try removing private mark…

1ae8ede

…er from APIs


          cleanup some comments; still debugging

2edfcf0

CodyCBakerPhD mentioned this pull request

[Refactor Flask I] Remove previous error filter #797

Merged

CodyCBakerPhD changed the title ~~[Refactor Flask I] Break up top-level~~ [Refactor Flask II] Break up top-level

CodyCBakerPhD changed the base branch from main to test_simple

May 25, 2024 20:51

CodyCBakerPhD changed the base branch from test_simple to swap_try_except_to_decorator

May 25, 2024 21:23

CodyCBakerPhD changed the title ~~[Refactor Flask II] Break up top-level~~ [Refactor Flask III] Break up top-level

CodyCBakerPhD and others added 2 commits

May 25, 2024 17:26


          Merge branch 'swap_try_except_to_decorator' into rebase_flask_refactor

227e3b3


          [pre-commit.ci] auto fixes from pre-commit.com hooks

ae58fc7

for more information, see https://pre-commit.ci

CodyCBakerPhD marked this pull request as draft

May 27, 2024 15:51

CodyCBakerPhD mentioned this pull request

[Refactor Flask III] Remove api.abort and other error handlers #798

Merged

CodyCBakerPhD changed the title ~~[Refactor Flask III] Break up top-level~~ ~~[Refactor Flask III] Break up top-level~~

CodyCBakerPhD mentioned this pull request

[Refactor Flask II] Break up top-level #799

Merged

Collaborator Author

CodyCBakerPhD commented May 28, 2024

replaced by many others

CodyCBakerPhD closed this

CodyCBakerPhD deleted the rebase_flask_refactor branch

June 17, 2024 18:50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet