Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates envs #947

Merged
merged 5 commits into from
Dec 9, 2024
Merged

updates envs #947

merged 5 commits into from
Dec 9, 2024

Conversation

luiztauffer
Copy link
Collaborator

@luiztauffer luiztauffer commented Dec 9, 2024

@luiztauffer luiztauffer requested a review from rly December 9, 2024 17:33
@luiztauffer
Copy link
Collaborator Author

@bendichter @rly this fixes the import errors happening on tests. It also fixes an error due to a test DLC data that has been removed from GIN

@bendichter
Copy link
Collaborator

LGTM!

Copy link
Collaborator

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@rly
Copy link
Collaborator

rly commented Dec 9, 2024

PR tests and daily tests pass on this branch. Looks great. Thank you @luiztauffer !

@rly rly merged commit ef3d888 into main Dec 9, 2024
50 checks passed
@rly rly deleted the fix-ndx-dependency-error branch December 9, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily ExampleData tests failing
3 participants